Conversation
BIP-93 credits its first two authors as one entry sharing one address:
Authors: Leon Olsson Curr and Pearlwort Sneed <pearlwort@wpsoftware.net>
Andrew Poelstra <andrew.poelstra@gmail.com>
The table row split that entry on a comma, which reads as three authors with
three addresses. buildtable.pl keeps the name ahead of each address intact and
joins entries with a comma, so it renders the row the other way.
With this, the committed table matches the generated one everywhere except the
three "BIP number allocated" rows for 40, 41 and 63, which have no files for
the script to read and are maintained by hand.
With the README row now matching the generated table, the expected delta for BIP 93 no longer occurs and the Diff Checks job fails on the stale entry.
kriss39
force-pushed
the
fix/readme-bip93-authors
branch
from
September 13, 2026 16:15
294fa87 to
4d00a43
Compare
jonatack
reviewed
Sep 14, 2026
jonatack
left a comment
jonatack
left a comment
Member
There was a problem hiding this comment.
Thank you for your proposal, but I think it's better as it currently is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP-93 credits its first two authors as a single entry sharing one address:
The table row split that entry on a comma, so it reads as three authors with three addresses.
buildtable.plkeeps the whole name ahead of each address and joins entries with a comma, so it renders the row asLeon Olsson Curr and Pearlwort Sneed, Andrew Poelstra.Running
scripts/buildtable.pland diffing against the committed table, this was the only row where the two disagreed on content. With this change the two match everywhere except theBIP number allocatedrows for 40, 41 and 63, which have no files for the script to read and are maintained by hand.scripts/link-format-chk.sh,scripts/buildtable.plandtyposall still pass.